Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve related stock section on stock details page and add related seedlot info specific to plot and plant details pages ("source of" or "derived from" type) #4755

Merged
merged 10 commits into from
Dec 11, 2023
Merged

Improve related stock section on stock details page and add related seedlot info specific to plot and plant details pages ("source of" or "derived from" type) #4755

merged 10 commits into from
Dec 11, 2023

Conversation

titima15
Copy link
Contributor

@titima15 titima15 commented Dec 6, 2023

Description

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

@titima15 titima15 mentioned this pull request Dec 6, 2023
Closed
@titima15 titima15 requested review from nmenda and dwaring87 December 6, 2023 19:48
dwaring87
dwaring87 approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@dwaring87 dwaring87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! This makes the related stocks much clearer. I think you mentioned this in the lab meeting, but it would be very useful to have the trial name more prominently displayed on the stock detail page for a plot/subplot/plant.

@titima15
Copy link
Contributor Author

titima15 commented Dec 8, 2023

@dwaring87 Yes, I was planning to include that change in another pull request. Thanks for reviewing this pull request :-)

@darekbienkowski darekbienkowski merged commit b95d1c0 into master Dec 11, 2023
1 check passed
@darekbienkowski darekbienkowski deleted the topic/plot_info branch December 11, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwaring87 dwaring87 dwaring87 approved these changes

@nmenda nmenda nmenda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@titima15 @nmenda @dwaring87 @darekbienkowski